Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEO adjustments for KB forums and user-related links #5320

Merged
merged 11 commits into from Jan 9, 2023
Merged

SEO adjustments for KB forums and user-related links #5320

merged 11 commits into from Jan 9, 2023

Conversation

escattone
Copy link
Contributor

@escattone escattone commented Dec 7, 2022 •
edited

mozilla/sumo#1131

This PR does the following:

  • adds rel="nofollow" to all user links (NOTE: I didn't consider user links as "content" so I didn't use ugc)
  • disallows crawling of the KB forums, which are user-generated discussions of KB articles, via robots.txt
  • adds rel="ugc nofollow" to all KB forum links
  • adds tests
  • adds a doc for notes and policies related to SEO
@escattone escattone force-pushed the disallow-crawling-kb-forums-1132 branch from 839ee6c to 4279057 Compare December 7, 2022 15:45
@escattone escattone marked this pull request as ready for review December 7, 2022 17:45
@escattone escattone force-pushed the disallow-crawling-kb-forums-1132 branch from 4279057 to 2dcb6d8 Compare December 8, 2022 00:46
@escattone escattone force-pushed the disallow-crawling-kb-forums-1132 branch from c347685 to a4151e8 Compare December 10, 2022 00:13
@escattone escattone changed the title Disallow crawling of KB forums Dec 14, 2022
@escattone escattone mentioned this pull request Jan 4, 2023
Closed
@escattone escattone marked this pull request as draft January 4, 2023 01:07
@escattone escattone force-pushed the disallow-crawling-kb-forums-1132 branch 3 times, most recently from 6ee8026 to cd6ace7 Compare January 5, 2023 00:14
@escattone escattone force-pushed the disallow-crawling-kb-forums-1132 branch from cd6ace7 to bbc9acf Compare January 5, 2023 00:16
@escattone escattone marked this pull request as ready for review January 5, 2023 00:26
@escattone escattone changed the title disallow crawling of KB forums Jan 5, 2023
@akatsoulas
Copy link
Collaborator

@escattone do you intend to merge all the changes in a single commit or in multiple?
If it's the latter I would suggest to reshape a bit this PR and make the commits more atomic. For example there are 3 commits for tests, 2 for users etc. If it's the former please ignore my comment
@escattone
Copy link
Contributor Author

@akatsoulas I was planning on doing a squash and merge single commit.
akatsoulas
akatsoulas approved these changes Jan 9, 2023
View changes
Copy link
Collaborator

@akatsoulas akatsoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Let's make sure that we have an issue for QA in the sumo repo. Feel free to merge
@escattone escattone merged commit 7e760ba into mozilla:main Jan 9, 2023
2 checks passed
@escattone escattone deleted the disallow-crawling-kb-forums-1132 branch January 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@escattone @akatsoulas