Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seperate bulk-count es7_reindex option into sql and elastic ones #4657

merged 3 commits into from Feb 2, 2021


Copy link

@LeoMcA LeoMcA commented Jan 29, 2021

set defaults which shouldn't cause timeouts on prod


set defaults which shouldn't cause timeouts on prod

Copy link

@akatsoulas akatsoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a bit confusing if you revisit this code in a few months. Specifically why the DB slice is needed. I wonder if there is any room to add a couple of notes either in the code or the documentation.

Apart from that, can we bump the SQL query slice to 1K docs for example? Is there any reason not to?

Looks good r+wc

@LeoMcA LeoMcA merged commit d4a8426 into mozilla:master Feb 2, 2021
1 check passed
@LeoMcA LeoMcA deleted the reduce-default-bulk-chunk branch February 2, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants