seperate bulk-count es7_reindex option into sql and elastic ones #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set defaults which shouldn't cause timeouts on prod mozilla/sumo#742
akatsoulas
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
This can be a bit confusing if you revisit this code in a few months. Specifically why the DB slice is needed. I wonder if there is any room to add a couple of notes either in the code or the documentation.
Apart from that, can we bump the SQL query slice to 1K docs for example? Is there any reason not to?
Looks good r+wc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
set defaults which shouldn't cause timeouts on prod
mozilla/sumo#742